Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Pause reply after end" doesn't always show last move #1276

Open
5 tasks done
rajun274 opened this issue Mar 17, 2024 · 1 comment
Open
5 tasks done

"Pause reply after end" doesn't always show last move #1276

rajun274 opened this issue Mar 17, 2024 · 1 comment
Labels
bug Something is not working properly feat: engine Affected feature: Base engine

Comments

@rajun274
Copy link

rajun274 commented Mar 17, 2024

Checklist

  • I've checked both open and recently closed issues to ensure this issue is not already reported.
  • I am using the newest version of TETR.IO.
  • I am using a supported browser or the Desktop Client.
  • I am not using anything that modifies game code (e.g. TETR.IO PLUS).
  • I am certain this is a bug, not a feature request.

OS and Version

HP Elite Dragonfly 13.5 2022 (16GB) Chromebook

Browser and version

Chrome Version 121.0.6167.212 (Official Build) (64-bit)

Describe the bug/issue

"Pause reply after end" doesn't always show the very last move that a player does, probably because of some timing issue.

Reproducing

Steps to reproduce:

  1. Go to this replay file, which is pointing to the 3rd match: https://tetr.io/#R:MmREYZZ1I@3
  2. The default watch mode is "Exit replay after end".
  3. Watch player DERKMEH until the very end. You'll see that their last moves are LEFT and then HARD DROP:
    exit_reply_after_end
  4. Go back to that match, but change the watch mode to "Pause reply after end".
  5. Again, watch player DERKMEH until the very end. When the player pauses, the game omits the LEFT:
    pause_reply_after_end

Note that in my reproduction, it's quite obvious why DERKMEH loses regardless of which watch mode you do. But I reckon that in a scenario where the player misdrops an I piece into a 4-wide well that's in the middle of the board, and they watch the replay and reproduce this bug, it will confuse the player as to why they lost.

Expected behavior

When the video pauses when watching in mode "Pause reply after end", it should show the very last move that all players do.

Screenshots

No response

Console logs

Likely not needed.

Additional context

No response

@rajun274 rajun274 added the bug Something is not working properly label Mar 17, 2024
@ZaptorZap ZaptorZap added the feat: engine Affected feature: Base engine label Mar 17, 2024
@p1nkl0bst3r
Copy link

related: #605 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working properly feat: engine Affected feature: Base engine
Projects
None yet
Development

No branches or pull requests

3 participants