Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type of pane's ySplit attribute is wrong #388

Open
amoe opened this issue May 22, 2019 · 1 comment · Fixed by musshorn/xlnt#1 or doomlaur/xlnt#2 · May be fixed by #688
Open

Type of pane's ySplit attribute is wrong #388

amoe opened this issue May 22, 2019 · 1 comment · Fixed by musshorn/xlnt#1 or doomlaur/xlnt#2 · May be fixed by #688
Assignees
@tfussell
Labels
bug high priority
Milestone
v1.6

Comments

@amoe
Copy link

amoe commented May 22, 2019

The type of ySplit in the pane is set as row_t, but it should be some fractional type. This causes the following error.

terminate called after throwing an instance of 'xml::parsing'
   what():  xl/worksheets/sheet2.xml:2:656: error: invalid value '1.0'

https://docs.microsoft.com/en-us/previous-versions/office/developer/office-2010/cc880269(v%3Doffice.14)

https://github.com/tfussell/xlnt/blob/master/source/detail/serialization/xlsx_consumer.cpp#L515

This document was generated by exporting from Google Docs.
@tfussell
Copy link
Owner

I only wrote the xSplit and ySplit handling code for pane freezing. I didn't know that there were other kinds of non-integer splits. I'm working on this now.

@tfussell tfussell self-assigned this Jul 23, 2019
@tfussell tfussell mentioned this issue Aug 13, 2022
Open
@tfussell tfussell added this to the v1.6 milestone Aug 13, 2022
musshorn added a commit to musshorn/xlnt that referenced this issue Nov 22, 2022
@musshorn
Update pane struct to match spec
e61f807 
Fixes tfussell#388
This was referenced Nov 22, 2022
Open
Merged
@doomlaur doomlaur mentioned this issue May 22, 2024
Merged
doomlaur added a commit to doomlaur/xlnt that referenced this issue May 22, 2024
@doomlaur
Merge pull request #2 from musshorn/issue_388
2c59134 
Update pane struct to match spec - fix XLNT issue tfussell#388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfussell tfussell

Labels
bug high priority
Projects
None yet
Milestone
v1.6
2 participants
@amoe @tfussell