Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

number_serialiser::deserialise returns wrong result due to buffer not being null terminated #714

Open
m7913d opened this issue Sep 20, 2023 · 0 comments · May be fixed by #715
Open

number_serialiser::deserialise returns wrong result due to buffer not being null terminated #714

m7913d opened this issue Sep 20, 2023 · 0 comments · May be fixed by #715

Comments

@m7913d
Copy link

m7913d commented Sep 20, 2023

Random numbers may be appended to the parsed number: f.ex. "1.2" may be parsed as 1.29 if should_convert_comma is true.

The problem is that the char buf[30]; is never initialised, nor the null terminator is copied from the source string. Doing one of both fixes the issue.
m7913d added a commit to m7913d/xlnt that referenced this issue Sep 23, 2023
@m7913d
Correctly copy the null terminator
adda698 
Fixes tfussell#714
@m7913d m7913d linked a pull request Sep 23, 2023 that will close this issue
Open
m7913d added a commit to m7913d/xlnt that referenced this issue Sep 23, 2023
@m7913d
Correctly copy the null terminator
33dd551 
Fixes tfussell#714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly copy the null terminator m7913d/xlnt
1 participant
@m7913d