Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency paths on targets that generate subrepos aren't surfaced #3001

Open
peterebden opened this issue Dec 20, 2023 · 0 comments
Open

Dependency paths on targets that generate subrepos aren't surfaced #3001

peterebden opened this issue Dec 20, 2023 · 0 comments

Comments

@peterebden
Copy link
Member

An example is probably worth a thousand (or at least several hundred) words:

$ plz query somepath //src:please //third_party/go:_golang.org_x_term#dl
Couldn't find any dependency path between //src:please and //third_party/go:_golang.org_x_term#dl

Clearly there is a dependency here in a real sense, since Please uses x/term and that #dl target is the thing that downloads the files for it. Ideally queries should surface this relationship.
(The same is true for //third_party/go:golang.org_x_term)

This is an issue for getting go_repo targets labelled correctly (see please-build/go-rules#192)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant