Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRO]: Deleting node with comment mark does not delete comment #5076

Open
2 tasks done
EricHasegawa opened this issue Apr 17, 2024 · 0 comments
Open
2 tasks done

[PRO]: Deleting node with comment mark does not delete comment #5076

EricHasegawa opened this issue Apr 17, 2024 · 0 comments
Labels
Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@EricHasegawa
Copy link
Contributor

Which packages did you experience the bug in?

comments

What Tiptap version are you using?

"@tiptap-pro/extension-comments": "^2.8.1",

What’s the bug you are facing?

Deleting a comment node/mark in the editor does not propagate the delete to the thread. If you make a comment on some text, then delete the text, the comment still exists as a “dangling comment”.

Steps to reproduce:

  1. Leave a comment on a paragraph
  2. Delete the paragraph
  3. See that the comment still exists

This is reproducible in your comments demo here.

What browser are you using?

Chrome

Code example

https://tiptap.dev/docs/editor/comments/overview

What did you expect to happen?

Deleting the text with the comment mark applied causes the comment to be deleted.

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@EricHasegawa EricHasegawa added Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
Status: Triage open
Development

No branches or pull requests

1 participant