Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRO]: Undo does not work properly with comments #5077

Open
2 tasks done
EricHasegawa opened this issue Apr 17, 2024 · 0 comments
Open
2 tasks done

[PRO]: Undo does not work properly with comments #5077

EricHasegawa opened this issue Apr 17, 2024 · 0 comments
Labels
Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@EricHasegawa
Copy link
Contributor

Which packages did you experience the bug in?

comments

What Tiptap version are you using?

"@tiptap-pro/extension-comments": "^2.8.1",

What’s the bug you are facing?

Undo does not seem to work properly with comments, there’s two types of errors here:

  1. Undo removes the mark but doesn’t delete the comment.
    Steps to reproduce:

    1. Leave a comment on some text
    2. Undo
    3. See that the comment mark is deleted but the comment still exists.
  2. Undo removes the comment but leaves the mark.

    1. Leave a comment on some text
    2. Edit the comment
    3. Undo
    4. See the comment is deleted but the comment mark still exists (now points to nothing)

This is reproducible in the comments demo here

What browser are you using?

Chrome

Code example

https://tiptap.dev/docs/editor/comments/overview

What did you expect to happen?

Undo will either delete or restore both the comment and the mark, not one or the other.

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@EricHasegawa EricHasegawa added Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
Status: Triage open
Development

No branches or pull requests

1 participant