Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of AST parse #418

Open
styfle opened this issue May 15, 2024 · 0 comments
Open

Improve performance of AST parse #418

styfle opened this issue May 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@styfle
Copy link
Member

styfle commented May 15, 2024

We currently use acorn for parsing JS into the AST, however there are faster alternatives now.

One of the fastest, @swc/core, is used by Next.js so its perhaps possible to parse once and share the AST so that nft wouldn't need to parse again. However, this could lead to a major rewrite since the AST is not compatible.

Another alternative, hermes-parser, is used by React Native and should have the same AST format (ESTree) which might mean its a drop-in replacement for acorn.

@styfle styfle added the enhancement New feature or request label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant