Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter support issues. #14

Open
sectroyer opened this issue May 18, 2023 · 8 comments
Open

Parameter support issues. #14

sectroyer opened this issue May 18, 2023 · 8 comments
Labels
delayed The issue will be fixed with a big update later documentation Improvements or additions to documentation

Comments

@sectroyer
Copy link

sectroyer commented May 18, 2023

SSTImap lacks '-p' (or equivalent) switch for specifying injection parameter.

Also it would be nice to have some improvement in case of multiple parameters like here:

[*] Javascript plugin is testing rendering with tag '*'
[*] Javascript plugin is testing ;*// code context escape with 6 variations
[*] Javascript plugin is testing blind injection
[*] Javascript plugin is testing ;*// code context escape with 6 variations
[*] Testing if POST parameter 'csrf' is injectable
[*] Ejs plugin is testing rendering with tag '*'
[*] Ejs plugin is testing %>*<%# code context escape with 6 variations
[*] Ejs plugin is testing blind injection
[*] Ejs plugin is testing %>*<%# code context escape with 6 variations
[*] Freemarker plugin is testing rendering with tag '*'
[*] Freemarker plugin is testing }* code context escape with 6 va

It's hard to find a line where it switches to new parameter. Even change to something like this would help a lot:

[*] Javascript plugin is testing rendering with tag '*'
[*] Javascript plugin is testing ;*// code context escape with 6 variations
[*] Javascript plugin is testing blind injection
[*] Javascript plugin is testing ;*// code context escape with 6 variations

[*] Testing if POST parameter 'csrf' is injectable
[*] Ejs plugin is testing rendering with tag '*'
[*] Ejs plugin is testing %>*<%# code context escape with 6 variations
[*] Ejs plugin is testing blind injection
[*] Ejs plugin is testing %>*<%# code context escape with 6 variations
[*] Freemarker plugin is testing rendering with tag '*'
[*] Freemarker plugin is testing }* code context escape with 6 va

Maybe even a different color of the "Testing..." line...

@vladko312
Copy link
Owner

I will probably change the color. Also, have you set an injection marker (*) as a parameter you need?

@vladko312 vladko312 added enhancement New feature or request in progress The issue would be fixed in the next minor version labels May 20, 2023
@sectroyer
Copy link
Author

Nope I didn't. It wasn't clear for me if it works or not :)

@vladko312
Copy link
Owner

I made URL/form and parameter changing stand out a bit more.

Can you verify?

As for marker usage, it requires some documentation, so the issue will remain open for now.

@vladko312 vladko312 added documentation Improvements or additions to documentation awaits confirmation The issue is supposed to be resolved, but requires some testing and removed enhancement New feature or request in progress The issue would be fixed in the next minor version labels May 26, 2023
@sectroyer
Copy link
Author

Yes this green color looks much better 👍

@vladko312 vladko312 removed the awaits confirmation The issue is supposed to be resolved, but requires some testing label Jun 1, 2023
@vladko312
Copy link
Owner

Thank you for your feedback! I will close this issue after creating some documentation.

@vladko312 vladko312 added the delayed The issue will be fixed with a big update later label Jun 1, 2023
@sectroyer
Copy link
Author

After some more testing I have noticed one issue with current logging:
[*] Testing if POST parameter 'TEST' is injectable
Since it's in green and ends with "parameter XYZ is injectable" it often confuses me. Tough I know the tool and notice it after a second. Still I think something like this:
[*] Testing injection on POST parameter 'TEST'
Especially since sqlmap logs "... is injectable" so that's probably why it confuses me 😄

@vladko312
Copy link
Owner

Maybe, I will change the colour to yellow and change the text as well

@vladko312
Copy link
Owner

Should be more clear in 1.2.0
Can you verify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delayed The issue will be fixed with a big update later documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants