handle *grep errors #217
Merged
handle *grep errors #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing as the eperm test doesn't work when running as root. |
|
Tested it and the behavior is as expected (both vgrep and the fzf integration). Thanks! |
|
Thanks a ton! I will get back to this PR next week trying to find a solution for CI. |
Try parsing the stdout of *grep even in case of an error. This allows to return output when hitting, for instance, eperms on certain files. The stderr of *grep is now logged directly while the exit code is being recorded and used by vgrep on exit. Fixes: #216 Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try parsing the stdout of *grep even in case of an error. This allows to return output when hitting, for instance, eperms on certain files.
The stderr of *grep is now logged directly while the exit code is being recorded and used by vgrep on exit.
Fixes: #216