Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make definition column on object type table non nullable #68

Open
kkajla12 opened this issue Apr 7, 2023 · 0 comments
Open

Make definition column on object type table non nullable #68

kkajla12 opened this issue Apr 7, 2023 · 0 comments
Labels
datastore Requires changes in the datastore layer enhancement New feature or request

Comments

@kkajla12
Copy link
Member

kkajla12 commented Apr 7, 2023

Is your feature request related to a problem? Please describe.
As currently defined, object type records in the database are allowed to have a NULL definition (this is also currently the default value if no value is provided for that column as part of the insert).

Describe the solution you'd like
The above behavior is incorrect and we should enforce that the definition column is not nullable at the database level (in addition to the application level enforcement already in place).

Describe alternatives you've considered
N/A

Additional context
We'll need to make sure this behavior is updated for all supported databases. Any migrations added to enforce this non-nullable constraint on the definition column should also be sure to handle existing object type records that might have a NULL definition.

@kkajla12 kkajla12 added enhancement New feature or request good first issue Good for newcomers labels Apr 7, 2023
@akajla09 akajla09 added the datastore Requires changes in the datastore layer label Jun 6, 2023
@akajla09 akajla09 removed the good first issue Good for newcomers label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datastore Requires changes in the datastore layer enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants