Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS Validation - Fallback to configured/system DNS servers when authoritative name servers for a domain cannot be contacted #2583

Closed
JT-Moore opened this issue May 18, 2024 · 6 comments

Comments

@JT-Moore
Copy link

In situations where a firewall prevents the client from sending DNS queries directly to any of the authoritative servers for a domain,
LookupClientProvider.GetNameServers() should fallback to using the configured or system DNS servers.

This can be easily implemented by changing the following line in LookupClientProvider.GetNameServers() from:

 verified = backup?.ToList() ?? new List<IPAddress>();

to:

 verified = backup?.ToList() ?? ParseDefaultClients();

Doing that would allow DNS validation plugins to work in environments where clients are required to only use specific recursive DNS servers.

@WouterTinus
Copy link
Member

At first glance I'd say your change doesn't actually change anything. When GetNameServers returns an empty list, CreateLookupResult falls back to the _systemclient, which uses those same defaultclients.

@JT-Moore
Copy link
Author

JT-Moore commented May 18, 2024 via email

@WouterTinus
Copy link
Member

I guess there is unfortunately no way to make them ignore their cached validation on their side

You could create a new account for that purpose.

@JT-Moore
Copy link
Author

JT-Moore commented May 18, 2024 via email

WouterTinus added a commit that referenced this issue May 19, 2024
@WouterTinus
Copy link
Member

Would it be possible to add support for that to win-acme?

That's been included in version 2.2.9.1

@JT-Moore
Copy link
Author

JT-Moore commented May 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants