You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
site is already being checked in onCreate and the activity is finished if the site is null.
The crash message is Attempt to invoke virtual method 'void org.wordpress.android.ui.bloggingreminders.BloggingRemindersViewModel.onBlogSettingsItemClicked(int)' on a null object reference. From the logs, I understand that the null object is BloggingRemindersViewModel, not site. Can you confirm?
site is already being checked in onCreate and the activity is finished if the site is null.
From what I understand, mSite can become null after onCreate is called (deletion or removal of a site) which is why a few other functions in this class are also doing a null check. I personally feel that it's safer to have than not, but open to discussion.
From the logs, I understand that the null object is BloggingRemindersViewModel, not site.
Good point, thank you for catching that! I've added a null check for BloggingRemindersViewModel as well to address the case where it isn't initialized. What do you think?
Thanks @irfano, I updated the release notes 👍 For future reference, how do we decide which bug/crash fixes to include there? I noticed a few other crash fixes didn't update this file.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordPress
Jetpack
Fixes #20840
This PR fixes a crash in
SiteSettingsFragmentwheremBloggingRemindersViewModel.onBlogSettingsItemClicked()is called on a null object.To Test:
I haven't been able to reproduce this crash, so code review + smoke test
My Site -> Site Settings -> Blogging -> Reminders.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):
WordPress.com sites and self-hosted Jetpack sites.Portrait and landscape orientations.Light and dark modes.Fonts: Larger, smaller and bold text.High contrast.Talkback.Languages with large words or with letters/accents not frequently used in English.Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)Large and small screen sizes. (Tablet and smaller phones)Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)