Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having no favourites set leads to the new Favourites-dialog having a functionless ".."-dummy-entry (since Kodi 20) #25218

Open
1 of 7 tasks
axbmcuser opened this issue May 15, 2024 · 1 comment
Labels
Triage: Confirmed issue has been reproduced by a team member

Comments

@axbmcuser
Copy link
Contributor

axbmcuser commented May 15, 2024

Bug report

Describe the bug

Having no favourites set leads to the new Favourites-window having a functionless ".."-dummy-entry (since Kodi 20)

Side note:
This happens with both "Show parent folder items" disabled and enabled.
So the entry is most likely not a broken "parent folder item" but some sort of dummy entry which becomes visible if the user has no favourites set.

Expected Behavior

Having no favourites set should lead to an fully empty Favourites-window

Actual Behavior

see above

Possible Fix

not sure

To Reproduce

see above

Debuglog

.

Screenshots

emptyfav

Additional context or screenshots (if appropriate)

Your Environment

Used Operating system:

  • Android

  • iOS

  • tvOS

  • Linux

  • macOS

  • Windows

  • Windows UWP

  • Operating system version/name: Windows 10

  • Kodi version: Kodi 20-22

@xbmc-gh-bot xbmc-gh-bot bot added the Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it label May 15, 2024
@axbmcuser axbmcuser changed the title Having no favourites set leads to the new Favourites-dialog having a functionless ".."-dummy-entry which does nothing (since Kodi 20) Having no favourites set leads to the new Favourites-dialog having a functionless ".."-dummy-entry (since Kodi 20) May 15, 2024
@ksooo ksooo added Triage: Confirmed issue has been reproduced by a team member and removed Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it labels May 29, 2024
@ksooo
Copy link
Member

ksooo commented May 29, 2024

Confirmed.

This is a technical limitation of the new Favourites GUI implementation which is based on a CMediaWindow which to my knowledge cannot be empty. Just for the records, not saying this needs no fix.

@ksooo ksooo changed the title Having no favourites set leads to the new Favourites-dialog having a functionless ".."-dummy-entry (since Kodi 20) Having no favourites set leads to the new Favourites-dialog having a functionless ".."-dummy-entry May 29, 2024
@ksooo ksooo changed the title Having no favourites set leads to the new Favourites-dialog having a functionless ".."-dummy-entry Having no favourites set leads to the new Favourites-dialog having a functionless ".."-dummy-entry (since Kodi 20) May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage: Confirmed issue has been reproduced by a team member
Projects
None yet
Development

No branches or pull requests

2 participants