Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometry tools don't take into account the shift key any more #5687

Closed
rolandlo opened this issue May 14, 2024 · 1 comment · Fixed by #5688
Closed

Geometry tools don't take into account the shift key any more #5687

rolandlo opened this issue May 14, 2024 · 1 comment · Fixed by #5688
Labels
bug regression This issue is about a regression from the previous release; or this PR fixes a regression.

Comments

@rolandlo
Copy link
Member

Operating System

Linux

(Linux only) Distribution

Ubuntu 24.04

(Linux only) Desktop Environment

Gnome

(Linux Only) Display Server

Wayland

Installation Method

PPA

Xournal++ Version

1.2.3+dev

libgtk Version

3.24.41

Bug Description

When scaling (with s/S) or rotating (r/R) a geometry tool (setsquare/compass) via the keyboard, the shift key is not taken into account any more. So the geometry tool can currently only be enlarged and rotated counter-clockwise via the keyboard, not shrinked or rotated clockwise.
The Alt key is still working.

Expected Behaviour

The geometry tools keyboard navigation should work like it did previously.

Steps to Reproduce

  1. Switch on the setsquare or compass
  2. Press s and Shift+s and notice there is no difference
  3. Press r and Shift+r and notice there is no difference

Additional Context

Probably a regression from #5646 (didn't check though).
@rolandlo rolandlo added the bug label May 14, 2024
@bhennion bhennion mentioned this issue May 14, 2024
Merged
@bhennion
Copy link
Contributor

Probably a regression from #5646 (didn't check though).

Indeed it was! See #5688

@bhennion bhennion added the regression This issue is about a regression from the previous release; or this PR fixes a regression. label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression This issue is about a regression from the previous release; or this PR fixes a regression.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix geometric tool keyboard accelerators bhennion/xournalpp
2 participants
@bhennion @rolandlo