Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlas and game.png file generation should make exceptions accessible to a Modder #11618

Closed
1 task done
RealBamboolord opened this issue May 18, 2024 · 9 comments · Fixed by #11620
Closed
1 task done
Labels

Comments

@RealBamboolord
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Game Version

4.11.13 (Build 997)

Describe the bug

https://github.com/RealBamboolord/Hadrodia-RP-game
When downloading this mod, the game isn't able to regenerate the atlas and png files to display icons and sprites. When deleting the existing game.png, game.atlas and atlases.json files, the game won't generate them new when I restart the game.

Steps to Reproduce

  1. Download the mod using the link provided above
  2. Go to mods folder and delete the existing atlases.json, game.png and game.atlas files
  3. Restart the game
  4. See that the files didn't regenerate

Screenshots

No response

Link to save file

No response

Operating System

Windows

Additional Information

I have checked all Image file to make sure they are all .png files and tried to figure out which files where causing the error, although I was unsuccessful. Individually deleting the Images subfolders didn't fix the issue. I would therefor like to know what file is causing the issue or what the problem seems to be.

@SomeTroglodyte SomeTroglodyte changed the title Atlas and game.png file generation doesn't work Atlas and game.png file generation should make exceptions accessible to a Modder May 18, 2024
@SomeTroglodyte
Copy link
Collaborator

Me brutal - uga uga - title and label me barsh

image

A little small, but your Autistica.png seems bad (and I hope that's no minority disrespect). Let's see how gimp likes the file...

@SomeTroglodyte
Copy link
Collaborator

No gimp needed, a quick hex view says that's a webp renamed to png, not an actual png

@SomeTroglodyte
Copy link
Collaborator

.. and gimp doesn't complain, but open + export/overwrite, nothing else, immediately converts it, and Unciv packer accepts it. Only to stumble over the next, Darkian Empire.png - same crap.

@SomeTroglodyte
Copy link
Collaborator

How about...

image

@RealBamboolord
Copy link
Contributor Author

Thanks SomeTrog

@SomeTroglodyte
Copy link
Collaborator

Interesting thing... The industry failing to get the file type issue finally solved - it's getting worse not better. And every app I can think of will silently display the webp with the unfitting name/extension. ImageMagick can tell you what's up, or MediaInfo - or a hex viewer. None of them are in widespread everyday use.

@yairm210
Copy link
Owner

That's some mindbending stuff

@SomeTroglodyte
Copy link
Collaborator

mindbending

Zac McCracken!!!!

... yea, I was planning to offer this as a joke, then revert everything but the console log, then demand modders run from a shell to see one bad image fingered, fix, rerun, fix next ...

But I reconsidered because a) BamboozleLord - oops, VamooseLord... oops, RealBamboolord had four of them, a significant percentage. b) q: why were they bad? a: some website already lied about the format, not our modder. c) After looking for alternatives how to see a renamed webp... See above, but since I found another one: Pix, when you change its "browse" config to show type under the thumbs..... Anyway, very few options, most apps silently ignore.

@RealBamboolord
Copy link
Contributor Author

Blame Discord, they now for no reason change everything to webp if you aren't careful. Even stuff uploaded as png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants