Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello Yale8848! #187

Open
jtm0609 opened this issue Mar 15, 2021 · 3 comments
Open

Hello Yale8848! #187

jtm0609 opened this issue Mar 15, 2021 · 3 comments

Comments

@jtm0609
Copy link

jtm0609 commented Mar 15, 2021

Mobile: Galaxy s10

Android OS: 10.0

NetWork: WIFI

URL:

LIB Version: ren.yale.android:cachewebviewlib:2.1.8


Hello, yale8848
I'm getting a lot of help thanks to your code.
But I have a questions.

builder.setCacheSize(1024 * 1024 * 1500)

there be a performance problem if we designate such a large number?

@yale8848
Copy link
Owner

I think it have not performance problem , because it use OkHttp OkHttp cache method like under code:

OkHttpClient.Builder builder = new OkHttpClient.Builder()
                .cache(cache)

@jtm0609
Copy link
Author

jtm0609 commented Mar 17, 2021

Thank you for answering my question.
Oh, isn't it stored in the application package's cache memory?
What you're saying is that there's no performance problem because we use the cache memory of okHttp library, right?

@yale8848
Copy link
Owner

The whole cache solution is the same of OkHttp, so you can check OkHttp lib cache method whether fit for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants