Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need demo for prosemirror #1

Open
alex521 opened this issue Dec 15, 2020 · 7 comments
Open

need demo for prosemirror #1

alex521 opened this issue Dec 15, 2020 · 7 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@alex521
Copy link

alex521 commented Dec 15, 2020

Use github issues for bug reports and feature requests. For general questions, please use https://discuss.yjs.dev/
if use signalr on server , how to use y-prosemirror for client ?

@alex521 alex521 added the wontfix This will not be worked on label Dec 15, 2020
@dmonad
Copy link
Member

dmonad commented Dec 15, 2020

Hi @aleksk ,

There is a very extensive documentation, demo projects, and even a live-code editor that will help you to setup y-prosemirror. https://docs.yjs.dev/ecosystem/editor-bindings/prosemirror

Before you start using this project, you probably should get familiar with the general concepts of Yjs: https://docs.yjs.dev/getting-started/a-collaborative-editor

You can start with the sample app (https://github.com/yjs/ycs/tree/main/samples/YcsReactMonacoSample/ClientApp) and exchange Monaco for ProseMirror as described in the Yjs documentation.

@dmonad dmonad closed this as completed Dec 15, 2020
@aleksk aleksk self-assigned this Feb 1, 2021
@aleksk aleksk added documentation Improvements or additions to documentation and removed wontfix This will not be worked on labels Feb 1, 2021
@aleksk aleksk reopened this Feb 1, 2021
@aleksk aleksk added the bug Something isn't working label Feb 10, 2021
@aleksk
Copy link
Collaborator

aleksk commented Feb 10, 2021

ProseMirror requires Y.Xml types, which are not yet ported over from the Yjs :)
Created the component so far, but it's not enabled in the sample: https://github.com/yjs/ycs/blob/main/samples/YcsSample/ClientApp/src/components/proseMirror.tsx

@alex521
Copy link
Author

alex521 commented Feb 21, 2021

Failed to compile
./src/impl/yjsSignalrConnector.ts line 152
Attempted import error: 'encodeStateVectorV2' is not exported from 'yjs' (imported as 'Y').

@aleksk
Copy link
Collaborator

aleksk commented Feb 22, 2021

Can't repro the build issue on any of my machines. Maybe yjs dependency wasn't properly restored, or npm/tools are not up-to-date?

ycs\samples\YcsSample\ClientApp>npm run build
> ycs-sample@0.0.1 build C:\src\ycs\samples\YcsSample\ClientApp
> react-scripts build
Creating an optimized production build...
Compiled successfully.

@alex521
Copy link
Author

alex521 commented Mar 2, 2021

yjs version is 13.5.1 , can not find encodeStateVectorV2 function.

@dmonad
Copy link
Member

dmonad commented Mar 3, 2021

The v2 updates feature is not released yet. I removed encodeStateVectorV2 because I plan to make breaking changes to it.

@aleksk
Copy link
Collaborator

aleksk commented Mar 3, 2021

Updated packages.json to only use 3.4.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants