Add support for setting process name #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,7 +50,7 @@ def io_waitreadable_sleep | |||
| def test_slow_io_waitreadable_sleep | |||
| # This test hits IO::WaitReadable exception multiple times | |||
| # For that, this test must run longer than 1 second | |||
| assert measure_io_waitreadable_sleep > 1 | |||
| assert_operator measure_io_waitreadable_sleep, :>, 1 | |||
There was a problem hiding this comment.
Hi @iuri-gg,
thanks for posting that.
I have to check all the tests for styleguide puposes.
|
Hey @iuri-gg thanks for coming up with this improvement. It makes sense in any case. I would prefer to store the "id" of the process inside the context vars as well. So you can add those information to your own logs as well. I will check and come-up with more feedback Cheers |
|
Thanks Tom! Let me know how I can help. |
|
Hi Tom. Hope all is well. Just pinging on this issue to see if it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Updates process name for main thread with
[MidiSmtp] #{ARGV.join(' ')} (main)and for forked threads with[MidiSmtp] #{ARGV.join(' ')} (worker #{idx})Test case
Steps to check the changes:
ps aux | grep Midi) is[MidiSmtp] .... (main)Expected behavior
Thread names should start with
[MidiSmtp]System tested on (please complete the following information):