build: do not build python server if rust server is specified #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikBjare
reviewed
Jul 7, 2022
| endif | ||
| make --directory=aw-qt build | ||
| # The below is needed due to: https://github.com/ActivityWatch/activitywatch/issues/173 | ||
| make --directory=aw-client build | ||
| make --directory=aw-core build | ||
| ifdef SKIP_SERVER_RUST |
ErikBjare
reviewed
Jul 7, 2022
| @@ -48,14 +47,17 @@ ifndef SKIP_SERVER_RUST # Skip building aw-server-rust if SKIP_SERVER_RUST is d | |||
| else \ | |||
| echo 'Rust not found, skipping aw-server-rust!'; \ | |||
| fi | |||
| else | |||
| make --directory=aw-server build SKIP_WEBUI=$(SKIP_WEBUI) | |||
There was a problem hiding this comment.
This will break CI, which should build both (and building both should be the default).
ErikBjare
force-pushed
the
master
branch
4 times, most recently
from
3d1fcd1
to
7259e24
Compare
ErikBjare
force-pushed
the
master
branch
2 times, most recently
from
df13a96
to
10dfeda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.