Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play Sound Instruction for World Logic #9736

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Play Sound Instruction for World Logic #9736

wants to merge 31 commits into from

Conversation

Mythril382
Copy link
Contributor

I don't know how to implement loop sounds, so leave suggestions if possible.

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

@Mythril382 Mythril382 changed the title PlaySound Instruction for World Logic Play Sound Instruction for World Logic Apr 12, 2024
@JasonP01
Copy link
Contributor

The commit names are so real

@ApsZoldat
Copy link
Contributor

ApsZoldat commented May 26, 2024 •
edited

Yes you should
And so should i

@camelStyleUser
Copy link

i can indeed confirm that this code(commit 0067af0) compiles and runs if using the arc pr as localArc

@BlueTheCube
Copy link
Contributor

build always fail guh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anuken Anuken Anuken left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Mythril382 @JasonP01 @ApsZoldat @camelStyleUser @BlueTheCube @Anuken