Optionally Use Search Engine from JEI or REI #7311
Conversation
|
Thanks for this PR, this is an interesting feature. I'll need to take an in-depth look at this w.r.t. performance and behavior when JEI/REI are absent. |
| if (!AEConfig.instance().isSyncWithExternalSearch()) | ||
| filter.setFilterText(old); |
There was a problem hiding this comment.
Probably should not have this side effect even IF external search syncing is enabled hmm I will look at this
There was a problem hiding this comment.
Else the current search in jei will be overriden with the ae2 search, even if "sync with external search" is off. Thats the "fix" for it.
| var old = filter.getFilterText(); | ||
| filter.setFilterText(searchString); | ||
|
|
||
| var filtered = new ArrayList<>(); |
There was a problem hiding this comment.
List and raw type. Needs to be a set.
There was a problem hiding this comment.
I don't see why it's needed for type "Object".
Intellij doesn't either.
|
@MarkusTieger Sorry for not coming back to you earlier. I am in the process of moving master to Neoforge, so it'll take a while before I can get to this PR. All in all: it will take a while 😓 |
no problem |
|
Any progress? We all very need this change! :) |
I almost forgot this issue, thanks for reminding me. This week I am busy, but I should be able to update this pr in the next week. |
|
Also maybe add JEI sorting function? #7827 |
|
We no longer support JEI in 1.20.6+ at the moment, so that is not going to work... |
|
I guess this issue is no longer required and #7883 will resolve the issue with the bad search? |
Allows to use the Search Engine from JEI or REI.
This can be useful because it is annoying when you try to search something with the modid and the name like it is possible in JEI. For example "@ae2 crystal". Without it, it tries to search a mod with the name "ae2 crystal".
It is configurable in the Terminal Settings. (opt-out to disable btw)