Remove hard-coded disassembly item from crafting blocks, use recipe IDs instead #7396
Conversation
62832
force-pushed
the
cpu-disassembly
branch
from
d7bdcbb
to
13c3fcc
Compare
| inventory.setItem(inventory.selected, ItemStack.EMPTY); | ||
|
|
||
| for (var ingredient : recipe.get().getIngredients()) { | ||
| var ingredientStack = new ItemStack(ingredient.getItems()[0].getItem(), inventory.getSelected().getCount()); |
There was a problem hiding this comment.
Have to test for empty ingredient.
Also -> If the ingredient is a tag-ingredient, this may have VERY unintended consequences.
There was a problem hiding this comment.
Might it be a good idea then to outright prevent disassembly if a tag is used for the ingredient? Or, in general, suppressing disassembly if the ingredient can be of more than one item?
| } | ||
|
|
||
| private void disassemble(ItemStack stack, Player player) { | ||
| protected ResourceLocation getRecipeId() { |
There was a problem hiding this comment.
Rename -> getDisassembleRecipeId()
There was a problem hiding this comment.
And I am not sure this reverse lookup is a good idea. It might instead just be a property passed in at item creation time.
There was a problem hiding this comment.
I assumed this was okay to do from the fact that this is already done for portable cells.
Partly addresses #6934.