-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AE2 New Textures #7870
base: main
Are you sure you want to change the base?
AE2 New Textures #7870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little feedback, mainly about lingering comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a few TODO comment here, also some commented out old code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a few TODO comment here, also some commented out old code.
src/main/java/appeng/client/gui/me/common/StackSizeRenderer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are several commented out infoBar.addSpace() calls that have different values than before. I guess they can be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept these in case Devs would like to revert back some of the changes, or review what has been removed.
src/main/java/appeng/datagen/providers/models/DecorationModelProvider.java
Outdated
Show resolved
Hide resolved
@@ -107,23 +107,24 @@ public class ColorApplicatorItem extends AEBasePoweredItem | |||
Function.identity())); | |||
private static final BiMap<DyeColor, Item> VANILLA_DYES = EnumHashBiMap.create(DyeColor.class); | |||
|
|||
// TODO (RID): Sorted the colours according to the colour wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment could be removed.
Since the changes are so big, could we have a built in resourcepack of the old textures? |
As you can see, these are more than just texture changes. Having a resource pack of the old textures won't be possible with a lot of additional work to accommodate all the new record code, new icons, new GUI elements ..etc. If someone wants to spend the time and work on it, then be my guest. I personally don't see a reason why would anyone wants to use the old textures when the new textures are more refined. |
This PR includes: