Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AE2 New Textures #7870

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

Ridanisaurus
Copy link
Contributor

This PR includes:

  • Item Textures
  • Block Textures
  • Block Models
  • Render Code Changes
  • GUIs

Copy link
Contributor

@Mithi83 Mithi83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little feedback, mainly about lingering comments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few TODO comment here, also some commented out old code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few TODO comment here, also some commented out old code.

src/main/java/appeng/client/gui/WidgetContainer.java Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are several commented out infoBar.addSpace() calls that have different values than before. I guess they can be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept these in case Devs would like to revert back some of the changes, or review what has been removed.

@@ -107,23 +107,24 @@ public class ColorApplicatorItem extends AEBasePoweredItem
Function.identity()));
private static final BiMap<DyeColor, Item> VANILLA_DYES = EnumHashBiMap.create(DyeColor.class);

// TODO (RID): Sorted the colours according to the colour wheel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment could be removed.

@RuiXuqi
Copy link

RuiXuqi commented May 19, 2024

Since the changes are so big, could we have a built in resourcepack of the old textures?

@Ridanisaurus
Copy link
Contributor Author

Since the changes are so big, could we have a built in resourcepack of the old textures?

As you can see, these are more than just texture changes. Having a resource pack of the old textures won't be possible with a lot of additional work to accommodate all the new record code, new icons, new GUI elements ..etc.

If someone wants to spend the time and work on it, then be my guest. I personally don't see a reason why would anyone wants to use the old textures when the new textures are more refined.
I understand that the Light Mode is not for everyone, and it is such a drastic change. This is why I'm gonna be working on a Dark Mode version of the textures as a Texture Pack, but I won't port forward the old textures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants