New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scriptable Object Improvements #1069
base: master
Are you sure you want to change the base?
Scriptable Object Improvements #1069
Conversation
PudyJapan
commented
Oct 16, 2023
- The Asset Export Collection didn't account for nested scriptable objects. This is an attempt to fix that by adding scriptable objects with no names that are referenced by their pathid by another top level scriptable object
- Some scene components were written into scriptable asset, this commit fixes that, largely avoiding the "Do not use ReadObjectThreaded on scene objects" which caused a huge log and out of memory
- IsSceneObject checks for both condition either gameobject is not null or having the collection as scene. It happens sometimes that the gameobject is null but the monobehaivour is referenced by another monobehaviour that is a part of gameobject
- Overall the commit fixes some "Do not use ReadObjectThreaded on scene objects" and fixes a bunch of deadbeef generated guids
…jects. This is an attempt to fix that by adding scriptable objects with no names that are referenced by their pathid by another top level scriptable object - Some scene components were written into scriptable asset, this commit fixes that, largely avoiding the "Do not use ReadObjectThreaded on scene objects" which caused a huge log and out of memory - IsSceneObject checks for both condition either gameobject is not null or having the collection as scene. It happens sometimes that the gameobject is null but the monobehaivour is referenced by another monobehaviour that is a part of gameobject - Overall the commit fixes some "Do not use ReadObjectThreaded on scene objects" and fixes a bunch of deadbeef generated guids
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
Thank you for contributing! Unfortunately, I cannot accept this pull request as-is. There are some notable problems:
I hope my words are not too discouraging. Good luck in your revisions! |
@ds5678 Thank you for the feedback. I didn't know about FetchDependencies. I will update that later if I have time. |
How are things going? |