Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scriptable Object Improvements #1069

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PudyJapan
Copy link

  • The Asset Export Collection didn't account for nested scriptable objects. This is an attempt to fix that by adding scriptable objects with no names that are referenced by their pathid by another top level scriptable object
  • Some scene components were written into scriptable asset, this commit fixes that, largely avoiding the "Do not use ReadObjectThreaded on scene objects" which caused a huge log and out of memory
  • IsSceneObject checks for both condition either gameobject is not null or having the collection as scene. It happens sometimes that the gameobject is null but the monobehaivour is referenced by another monobehaviour that is a part of gameobject
  • Overall the commit fixes some "Do not use ReadObjectThreaded on scene objects" and fixes a bunch of deadbeef generated guids

…jects. This is an attempt to fix that by adding scriptable objects with no names that are referenced by their pathid by another top level scriptable object

- Some scene components were written into scriptable asset, this commit fixes that, largely avoiding the "Do not use ReadObjectThreaded on scene objects" which caused a huge log and out of memory
- IsSceneObject checks for both condition either gameobject is not null or having the collection as scene. It happens sometimes that the gameobject is null but the monobehaivour is referenced by another monobehaviour that is a part of gameobject
- Overall the commit fixes some "Do not use ReadObjectThreaded on scene objects" and fixes a bunch of deadbeef generated guids
@github-actions
Copy link

github-actions bot commented Oct 16, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@PudyJapan
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

ds5678 added a commit to AssetRipper/AgreementSignatures that referenced this pull request Oct 16, 2023
@PudyJapan
Copy link
Author

recheck

@ds5678
Copy link
Collaborator

ds5678 commented Oct 16, 2023

Thank you for contributing!

Unfortunately, I cannot accept this pull request as-is. There are some notable problems:

  • Your AssetExportCollection changes violate the Single Responsibility Principal. You should make a new class that inherits from either it or AssetsExportCollection.
  • Similarly, SerializableField and SerializableStructure also violate the principal. You should find some other way to acquire your sub-MonoBehaviours, such as the FetchDependencies method.

I hope my words are not too discouraging. Good luck in your revisions!

@PudyJapan
Copy link
Author

@ds5678 Thank you for the feedback. I didn't know about FetchDependencies. I will update that later if I have time.

@ds5678 ds5678 changed the title - The Asset Export Collection didn't account for nested scriptable ob… Scriptable Object Improvements Nov 6, 2023
@ds5678
Copy link
Collaborator

ds5678 commented Feb 13, 2024

How are things going?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants