Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameBundle: skip failed files #1208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

davispuh
Copy link

Parsing some files might fail due to various reasons in such case still proceed with remaining files.

Parsing some files might fail due to various reasons
in such case still proceed with remaining files
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@ds5678
Copy link
Collaborator

ds5678 commented Feb 20, 2024

might fail due to various reasons

I want these listed.

@davispuh
Copy link
Author

might fail due to various reasons

I want these listed.

One reason can be encrypted global-metadata.dat, some games do that.

@ds5678
Copy link
Collaborator

ds5678 commented Feb 20, 2024

might fail due to various reasons

I want these listed.

One reason can be encrypted global-metadata.dat, some games do that.

I'd like to see the stack trace for that because I don't think your code would affect an encrypted metadata.

@ds5678
Copy link
Collaborator

ds5678 commented Feb 20, 2024

In any case, this is not how I would want this "issue" resolved. I would be more in favor of a CompressedResourceFile class that contains the compressed data when decompression fails or some type of "failed file" class. I am not okay with just printing a message into the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants