-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix call to liquidprompt function #2175
base: master
Are you sure you want to change the base?
Conversation
Missing leading underscore in `_lp_escape`
Relevant information from Version 2.0 Upgrade Notes (dated Oct 6): _lp_escape()Renamed to Replace assignment statements like:
with:
_lp_bzr_branch()Return changed from Recommended that Replace assignment statements like::
with::
|
Best I can tell this meets the requirements for the recent 2.0 version, but if we publish it as-is, isn't it going to break the existing installations? Not sure what the best way to deal with it is? |
Added `ret` to local declarations as per provided liquidprompt change notes
@davidpfarrell I am on the case |
It got a bit hairy at one point, but what I have done is: Introduced some auxiliary functions
These functions are unset before the sourcing of Liquidprompt, to provide a clean slate if reloading the shell etc. Updated I think a good practice going forward would be to pin the version of Liquidpromt to a tagged version, maybe via some env var, and print a warning/disclaimer if it's ever changed from the default. |
Missing leading underscore in
_lp_escape
Description
Motivation and Context
Without this - presumably - the code fails silently, never presenting the branch name in the PS1 prompt.
How Has This Been Tested?
Forgive me if there are tests for themes, but I could not find any; I personally tested this by cd'ing into and out of Git clone directories with and without the fix.
Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.