Refactors parallax subsystem

[EvilDragonfiend]

About The Pull Request

Refactors parallax subsystem

Unless I didn't read the profile wrong, it is 200% efficient than old parallax code.

What's different?

• Parallax code has been using screen_loc and changing it directly
• screen_loc has two issues:
  • it will not render an image when a thing is away from your screen
  • calculating the offset values has been done quite manually, and has been taking it as a raw text
• view_o() proc was called everytime, and this proc resets all parallax appearance and re-adds what it was already.
  • changing your view size makes glitch because parallax image amount is based on your view size
  • Initialize() is enough to handle this
• Parallax is now based on using transform = matrix() to change its location, and screen_loc = "CENTER-7,CENTER-7" will never be changed

Effectiveness

• CPU use efficiency is 200% better
• animating is much smoother than before

NOTE

I have no data on how efficient this is on live servers, so I removed some frozen parallax code. I should change that later with gethered data.

Why It's Good For The Game

Bacon has been blaming it, and I figured it was actually awfully coded.

Testing Photographs and Procedure

https://www.youtube.com/watch?v=QhK7EflY1do&ab_channel=EvilDragon

Changelog

🆑
code: improved parallax code
/:cl:

[EvilDragonfiend]

It's even faster with wait = 1

[PowerfulBacon]

It also will get called 2x as frequently, although since its an SS_BACKGROUND system this will result in an increased CPU usage only when there is enough time to spare anyway. The idea for making it wait = 2 was that the slight delay is barely noticable at slow speeds

[EvilDragonfiend]

Going to test this for a round. I will see how this is different.

[PowerfulBacon]

Include what you actually did to improve the performance and the methodology behind it, reviewers need to be able to go in and immediately know what you are trying to do rather than be forced to read 500 lines to figure out the intentions

[EvilDragonfiend]

Include what you actually did to improve the performance and the methodology behind it, reviewers need to be able to go in and immediately know what you are trying to do rather than be forced to read 500 lines to figure out the intentions

I kinda forgot it. Addressed now.

[EvilDragonfiend]

Round 48473, currently on.

[PowerfulBacon]

It also will get called 2x as frequently, although since its an SS_BACKGROUND system this will result in an increased CPU usage only when there is enough time to spare anyway. The idea for making it wait = 2 was that the slight delay is barely noticable at slow speeds

[PowerfulBacon]

The throttling was probably the most important part of the entire subsystem, the lag mitigation from the enumeration is great, but at high-pops a good majority of the time was spent processing the parallax for ghosts. Ghosts are extremely problematic at high pop because they are extremely fast and extremely plentiful. They cause everyones parallax to get lag mitigated. You really, really, should not delete the freezing of parallax layers for ghosts at high-pop since it will just bring back parallax's running slowly for humans at higher population limits.

[EvilDragonfiend]

Tiny clean up left

• Reviving parallax freeze()
• Fixing some comment
• FIxing some PR content

I didn't check CPU usage correctly yet.

[EvilDragonfiend]

Single testing on round 48561, pop +20