-
-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security mask dispatch PORT: "NSV13: Surviving edged weapons" #10930
Conversation
You certainly chose an... interesting direction with this. Having to manually pick the crime but having the location automatically picked out for you is backwards from the way it should be. The crime anyone commits isn't particularly relevant to call out over radio, that can be sorted at the brig. And I am against automatically calling out your exact location for two reasons. The first is that it removes any chance of ambushing security unless they get EMP'd, and EMPs are lame. All it takes is one click to activate the radial, one click to select any crime because it doesn't matter, instantly outed. At least with suit sensors there's a delay, and you have to stand still to type. An extra half a second can even the odds quite a bit. The second is that there are a lot of fuckily named rooms in the station that people won't actually understand where that is. For example part of the chemistry lab is called the apothecary. Who the hell is going to know where that is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, although some general comments about the super ease of access to location.
Something else that might need thinking about, is will security officers be wanted to wear their sec-masks 24/7 even while on green? Perhaps some kind of clothing accessory pager/radio device could allow you to use this without being forced to wear the mask.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please cite the source of where the sound file came from, or indicate if it was an original sound. The 🆑 should cite your name and the original authors of the NSV PR, and the NSV PR that you took code from should be provided in the body of the PR.
Can you show me how the icon looks like? |
Any changes you want, you can do yourself. I am not a coder, just porting on a request of a friend that plays on NSV. If you want me to change the mode entirely from grounds up, don't since I can't. I literally do not have the time. |
Me being a smoker dying with no backup because i didn't had my mask on because my addiction kicked in.. 😔 In all seriousness if it's for accessories well, cops IRL have radios attached to their vests so there's that or it could be some accessory for gloves, like some sort of mini Pip-boy I've always wanted some sort of dispatch, so it could be interested to see how it plays out.
I've read the note and it's true that not every crime needs to be there, can't say i disagree with those even if we don't see that many Riots, while having the crime in the dispatch would allow to know the ''severity and urgency'' of the backup i do agree with what Bacon said that it could be tweaked to make it a little more location-based but it could be worth a shot to try it as it is, and someone can pick it up and tweak it, also if you're unsure how to do certan stuff feel free to reach out on #coding on discord there's a lot of people that can help! |
I do like the idea of the pin to chest or radio of some sort. However as I mentioned. I am not a coder and do not have any idea how to do such. |
You don't actually need the hailer in your mask slot to use the callout, having it in your active inventory (like your pocket or hand) also works. Though I agree having a seperate accessory is probably better. |
Separate accessories can be added down the line. For now, I want to implement a basic version of it. |
I don't see the issue with the smoker trait having downsides. If you're stopping for a smoke you shouldn't be ready to engage in active combat |
Correct, that's why i said after the joke comment:
Leaving that aside, it was also to brainstorm other possible accesories that might work as dispatch so it doesn't rely on the mask(even if you can apparently use it if it's in your pocket as they mentioned above) i think it'll be nice to consider some sort of research-upgrades or accesories in the future if this gets merged, |
I'd leave the initial build at this as I've gone over all the basic issues that were pointed out. You can always make more items later down the line as add-ons and change it as needed for balance sake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few issues that I have which may require some major overhauls, if you are willing I can take a look at the code and make some additions.
- The sound effect is not tied to the radio message, and will play even if the radio is down or if the signals are jammed.
- The method for dealing with the icons needs improvement codewise (name and icon should be seperated)
- Being able to instantly broadcast the position is going to make these insanely strong and means that even a single brush with security will prompt the entire force to suddenly be on you, which might be a bit unfair. The mask should provide much more generalised areas which the user has to select. An alternative to choosing a location would be to just not broadcast the location at all and require a warden or AI to communicate positions.
- Having this be an accessory would be very nice, as then it doesn't force the mask to be worn (If it works in the pocket, that doesn't seem intentional).
- I would also like to be able to have an accessor on security officers which broadcasts their location should they fall down for a minute, which would be much better tied into an accessory than the sechailer mask.
I would love to make the changes you requested. I do have to mention that my understanding of byond code is... limited at best. So, you would pretty much have to make a PR into my PR or guide me through it slowly since I am near incapable of making these kinds of changes. Also, that last block
is a pretty amazing idea too. As security deaths are rampant with them being thrown into space not even a second later. We could totally try re-using the syndicate hard suit mini Hud where it points you towards it. Though I am unsure if that would be too strong, so you could perchance have it callout with some short 10 second delay or something so whoever killed the sec has a short moment steal ID or something? |
I want it to have a long, but unstoppable delay so if you kill a security officer you have a chance to loot them before needing to get away |
I generally approve that, but if that becomes the case... Can't they just. Take it off? It's the mask that's tracked, not officer. |
Killing the PR. Blame admin. |
About The Pull Request
Adds dispatch to security gas masks. Original code made by KMC on NSV, repurposed for Bee. "NSV13: Surviving edged weapons"
Why It's Good For The Game
Eases chat time for security to make a quick callout to a location for other officers to help.
resolves #10732
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑
add: Added dispatch option for the security hailer
soundadd: added sounds for hailer @Kmc2000
imageadd: added sprites for hailer @Kmc2000
/:cl: