Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wounds Atomization: Personalized Combat messages #10970

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented May 15, 2024

About The Pull Request

This is a PR porting tg's personalized combat messages, essentially attack messages like "Attacker bludgeoned Receiver in the head with a Fireaxe!" only appear to surrounding spectating parties. What the Attacker sees is "You bludgeon Receiver's head with a fireaxe!" and etcetera for Receivers message.

This is applied to all items that had a unique attack message, simplemob attacks, and all help, harm, disarm intent messages.

Includes the framework for the combat messages that show when you inflict wound of varying intensity on other carbons.

Ports:

Partial Port:

Why It's Good For The Game

Wounds atomization, less message spam.

Testing Photographs and Procedure

Screenshots&Videos

Screenshot 2024-05-15 130158

Changelog

🆑 rkz, Ryll/Shaps, KingofKosmos, Ghommie
add: personalized combat messages. Expect much more "you attack player" than "playername attacks player"
/:cl:

@Tsar-Salat Tsar-Salat requested review from itsmeow and a team as code owners May 15, 2024 17:10
@@ -112,6 +112,43 @@
playsound(get_turf(src), I.get_dismember_sound(), 80, 1)
return TRUE //successful attack

/mob/living/carbon/send_item_attack_message(obj/item/I, mob/living/user, hit_area, obj/item/bodypart/hit_bodypart)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wounds content

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant