Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn per Island + Soft Safe Spot Teleport #1984

Conversation

emmanuelvlad
Copy link
Contributor

@emmanuelvlad emmanuelvlad commented Jun 4, 2022

Spawn Per Island

  • added an option to allow spawn points per island by using /gamemode setspawn
    Using /gamemode will teleport to the spawn point instead of the home location
    For me it makes sense to have a spawn point different than homes, a nice setting to have per gamemode, it's disabled by default
  • Fixed an issue with island's center being in a negative Y coordinate /admin setspawnpoint didn't work in other dimensions

Soft Safe Spot Teleport

  • I made this because I have so many issues with the main SafeSpotTeleport never being consistent
    You can enable it with a setting, default is disabled
    What it does
    Finding the nearest safe spot only in the Y axis, if no block is found then it will make a glass block on the spawn point
    Not perfect, but it does the job done for me, I hope for other people too, could be improved.

Fixes

  • teleporting other entities than players when end and/or nether are disabled in server.properties
  • inTeleport flag was not removed on the player when using and end portal
  • pasting an island on other dimensions when the world's minHeight > islandHeight (It happens when setting area-height to a negative coordinate)

    To solve this I take the max value between world minHeight (+2) and island's height
    + 2 to give some space for bedrock to generate (in the nether for example)
  • an enum comparaison
  • formatting

@BONNe
Copy link
Member

BONNe commented Jun 4, 2022

Islands already have spawn-point.
Visit's addon uses it for player teleportation.

It is just players cannot change it.

Also, I am not sold on soft-safe-spot teleport. Most of BentoBox gamemodes uses Void Worlds. So it is easy to break one block and end up in a situation where in the whole Y column there are no blocks at all.

@emmanuelvlad
Copy link
Contributor Author

They are options, disabled by default.

For the SpawnPerIsland, It gives the player the ability to set the spawn location on each dimension.
Also it's used differently than homes, spawn-point is the spawn of the island, homes are homes

The SoftSafeSpotTeleport will create a block of glass if there is no block at the coordinates

@BONNe BONNe mentioned this pull request Jun 17, 2022
@tastybento tastybento closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants