Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add and implement OpRipeMd160, OP_SHA1, OP_SHA256, OP_HASH… #325

Merged
merged 2 commits into from Aug 8, 2018

Conversation

usatie
Copy link
Collaborator

@usatie usatie commented Aug 8, 2018

closes #103
closes #105
closes #106
closes #107
closes #108

Add

  • OP_RIPEMD160
  • OP_SHA1
  • OP_SHA256
  • OP_HASH256,
  • OP_CODESEPARATOR

@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #325 into master will decrease coverage by 0.22%.
The diff coverage is 31.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   44.83%   44.61%   -0.23%     
==========================================
  Files         114      119       +5     
  Lines        3856     3898      +42     
==========================================
+ Hits         1729     1739      +10     
- Misses       2127     2159      +32
Impacted Files Coverage Δ
BitcoinCashKit/Core/Crypto.swift 90.32% <0%> (-3.02%) ⬇️
BitcoinCashKit/Core/BitcoinCashKitPrivate.m 92.37% <0%> (-3.25%) ⬇️
BitcoinCashKit/Core/Scripts/Opcode.swift 100% <100%> (ø) ⬆️
...cripts/OP_CODE/Crypto Operators/OP_RIPEMD160.swift 25% <25%> (ø)
...ore/Scripts/OP_CODE/Crypto Operators/OP_SHA1.swift 25% <25%> (ø)
.../Scripts/OP_CODE/Crypto Operators/OP_HASH256.swift 25% <25%> (ø)
...e/Scripts/OP_CODE/Crypto Operators/OP_SHA256.swift 25% <25%> (ø)
...ts/OP_CODE/Crypto Operators/OP_CODESEPARATOR.swift 50% <50%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8cbe1d...665a216. Read the comment docs.

Copy link
Collaborator

@akifuji akifuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change OpExample() for new implemented OpCodes in OpCode.swift

@usatie
Copy link
Collaborator Author

usatie commented Aug 8, 2018

Yes, it's done.

Copy link
Collaborator

@akifuji akifuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous comment is wrong.
I overlooked... LGTM

@usatie usatie merged commit 0259d54 into master Aug 8, 2018
@usatie usatie deleted the add-crypto-opcodes branch August 8, 2018 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants