Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for other title/name possibilities if title is empty on geojson… #11637

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mfarmer-ara
Copy link

This adds an empty check to the initial name set for a GeoJsonDataSource. Adding this check allows it to fallback to checking other title/name possibilities a few lines below.

Example

Clicking each polygon in turn:

Current behavior (1.111)

  • Green = Title is not empty, shows "Actual Title"
  • Red = Title is empty and fallback possibility is not considered, shows ""

Changes here

  • Green = "Actual Title"
  • Red = "Fallback Title"

Closes #11633

@cesium-concierge
Copy link

Thank you so much for the pull request @mfarmer-ara! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ggetz
Copy link
Contributor

ggetz commented Nov 21, 2023

Thanks @mfarmer-ara. We'll need a Contributor License Agreement (CLA) in order to review this PR. Can you please submit one and comment back here once that's done?

@mfarmer-ara
Copy link
Author

I've sent a request to my company to get it filled out (yesterday). With the holiday this week it may be a little delayed. I'll revisit the remaining tasks as soon as it's sorted!

@mfarmer-ara
Copy link
Author

@ggetz I've updated the contributors file and received word that our team sent in the agreement for review.

@mfarmer-ara mfarmer-ara force-pushed the fallback-title-geojsondatasource branch from 1d68b86 to d0975ed Compare April 10, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve name fallback for GeoJSON
3 participants