Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- removing a keybinding from Unbound locally! makes it unresetable * #73644

Open
Brambor opened this issue May 11, 2024 · 1 comment
Open

- removing a keybinding from Unbound locally! makes it unresetable * #73644

Brambor opened this issue May 11, 2024 · 1 comment
Labels
Info / User Interface Game - player communication, menus, etc. (S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@Brambor
Copy link
Contributor

Brambor commented May 11, 2024

Describe the bug

- removing a keybinding from Unbound locally! by default. Then * Reset keybinding doesn't remove the *. An example is the Consume item (by type) below:
image

This could be confusing to the player.

Attach save file

N/A

Steps to reproduce

  1. Open Key Binding menu ?
  2. Search for consume
  3. Observe: Consume item (by type) is Unbound locally!
    • image
    • if not, remove entry with id of open_consume from CDDA\config\keybindings.json. Reload the save, and start at step 1.
  4. remove keybinding - for Consume item (by type)
  5. Observe: Consume item (by type) is Unbound globally!
    • image
  6. * Reset keybinding on Consume item (by type)
  7. Observe: nothing happens, it still has * as prefix denoting it is not default.

Expected behavior

The * disappears and it looks just like it did before editing.

It should reset it to empty list of local keybindings. I probably missed that, when implementing this in

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4291 (22H2)
  • Game Version: 0.G-9409-g1252fcee16 [64-bit] master was 6a8d75a
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

No response

@Brambor Brambor added (S1 - Need confirmation) Report waiting on confirmation of reproducibility Info / User Interface Game - player communication, menus, etc. labels May 11, 2024
@AdamALittle
Copy link

I am able to replicate this bug in experimental as well.

  • OS: Windows
    • OS Version: 10.0.19045.4291 (22H2)
  • Game Version: cdda-experimental-2024-05-14-1414 fc1c48f [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info / User Interface Game - player communication, menus, etc. (S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

2 participants