-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move isAllASCII
from UTFHelper to StringUtils
#64108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschu1ze
changed the title
Move isAllASCII from UTFHelper to StringUtils
Move May 19, 2024
isAllASCII
from UTFHelper to StringUtils
robot-ch-test-poll2
added
the
pr-not-for-changelog
This PR should not be mentioned in the changelog
label
May 19, 2024
This is an automated comment for commit 70637b2 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
alexey-milovidov
approved these changes
May 21, 2024
robot-ch-test-poll4
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
May 21, 2024
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
May 22, 2024
… from src/Common/StringUtils/StringUtils.h to src/Common/StringUtils.h. To avoid conflict, we rename StringUtils.h to GlutenStringUtils.h (cherry picked from commit 60f2b9e16accafd97e3135feb1036d877dbb363e)
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
May 22, 2024
… from src/Common/StringUtils/StringUtils.h to src/Common/StringUtils.h. To avoid conflict, we rename StringUtils.h to GlutenStringUtils.h (cherry picked from commit 60f2b9e16accafd97e3135feb1036d877dbb363e)
baibaichen
added a commit
to apache/incubator-gluten
that referenced
this pull request
May 22, 2024
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240522) * Fxi build due to ClickHouse/ClickHouse#64108 which move StringUtils.h from src/Common/StringUtils/StringUtils.h to src/Common/StringUtils.h. To avoid conflict, we rename StringUtils.h to GlutenStringUtils.h (cherry picked from commit 60f2b9e16accafd97e3135feb1036d877dbb363e) --------- Co-authored-by: kyligence-git <gluten@kyligence.io> Co-authored-by: Chang Chen <baibaichen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-not-for-changelog
This PR should not be mentioned in the changelog
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61632 introduced
isAllASCII
in UTFHelper. This function fits better into StringUtil.h/cpp to which I moved it.While doing so, I noticed that StringUtils.cpp is build into its own library since a very old PR: #1749. These days, this is no longer necessary, so I moved StringUtils.cpp back into Common/.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes
Modify your CI run
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: