Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly support native copy for azure #64116

Merged
merged 6 commits into from
May 20, 2024
Merged

Properly support native copy for azure #64116

merged 6 commits into from
May 20, 2024

Conversation

alesapin
Copy link
Member

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Now backups with azure blob storage will use multicopy.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • All with Azure
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-improvement Pull request with some product improvements label May 19, 2024
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented May 19, 2024 •
edited by robot-clickhouse-ci-1

This is an automated comment for commit 23e87ef with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Successful checks
Check nameDescriptionStatus
Docs checkBuilds and tests the documentation✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@kssenii kssenii self-assigned this May 19, 2024
azat and others added 2 commits May 19, 2024 22:37
@azat
Tune mmap_rnd_bits to workaround sanitizers issues
64a3080 
v1: vm.mmap_rnd_bits=28
v2: rebase with clang 18.1.6 + kernel.randomize_va_space=0
v3: leave only vm.mmap_rnd_bits=28 + use pre-run.sh (hope that it will
    be used), that way docker will not require --privileged and by some
    reason this breaks ASAN (though I cannot reproduce it)
v4: use actions/common_setup over init_runner.sh (it requires some
    manual deploy)
@alesapin
Merge remote-tracking branch 'azat/fix-sanitizers' into fix_azure_nat…
56d25c7 
…ive_copy
kssenii
kssenii approved these changes May 20, 2024
View reviewed changes
src/IO/AzureBlobStorage/copyAzureBlobStorageFile.cpp Outdated Show resolved Hide resolved
src/Backups/BackupIO_AzureBlobStorage.cpp Outdated Show resolved Hide resolved
src/Backups/BackupIO_AzureBlobStorage.cpp Outdated Show resolved Hide resolved
@alesapin alesapin enabled auto-merge May 20, 2024 09:55
alesapin and others added 3 commits May 20, 2024 11:55
@alesapin @kssenii
Update src/Backups/BackupIO_AzureBlobStorage.cpp
314752e 
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
@alesapin @kssenii
Update src/Backups/BackupIO_AzureBlobStorage.cpp
6a7a09a 
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
@alesapin
Review fix
23e87ef
@alesapin alesapin added this pull request to the merge queue May 20, 2024
Merged via the queue into master with commit 4ca2c0f May 20, 2024
8 of 12 checks passed
@alesapin alesapin deleted the fix_azure_native_copy branch May 20, 2024 10:21
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels
pr-backports-created-cloud pr-improvement Pull request with some product improvements pr-must-backport-cloud pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alesapin @robot-ch-test-poll2 @kssenii @robot-ch-test-poll1 @robot-clickhouse-ci-1 @azat