-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip create_dummy_source
when a target uses swift
#11845
base: master
Are you sure you want to change the base?
Skip create_dummy_source
when a target uses swift
#11845
Conversation
701c859
to
3ef99d7
Compare
My intention was to disable the creation of |
Needs to update integration specs. |
@dnkoutso thanks for taking a look. Created a PR for the specs update. |
14f9cc2
to
3d99cb9
Compare
3d99cb9
to
d1533b1
Compare
@dnkoutso, may I have a review? |
d1533b1
to
07a6a39
Compare
Looks great, this PR would be the first step towards #9649. |
Another thing is to remove the automatically generated PCH (precompiled header) file by CocoaPods. However, this is a disruptive modification that requires each file to declare its dependencies and import them explicitly. I'm not sure if I really want to do this, but it has dependencies in my other plan. |
Dummy does not need to be created when a Target uses swift.