Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variable candidate #2215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unused variable candidate #2215

wants to merge 1 commit into from
+1 −1

Conversation

gasull
Copy link

@gasull gasull commented Mar 26, 2021 •
edited

Related bug: #2213

This change is Reviewable

@gasull gasull mentioned this pull request Apr 1, 2021
Closed
@PiRK
Copy link

PiRK commented Apr 2, 2021

This method penalty_func on line 102 seems to be a dummy implementation that is not actually used anywhere. It is probably meant to document how the inheritor should implement the method. I think the solution would be to actually document the method in the base class with a docstring, and not implement it.

@PiRK
Copy link

PiRK commented Apr 2, 2021 •
edited

Oops, wrong github repo again :)

See my suggestion here: Bitcoin-ABC#102 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gasull @PiRK