Fix changed behavior of pipe_parallel #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megatron/neox_arguments/arguments.py
Outdated
| @@ -1035,7 +1035,7 @@ def calculate_derived(self): | |||
| # the sequential model without the PipelineModule wrapper to avoid the overhead it incurs | |||
| self.update_value( | |||
| "is_pipe_parallel", | |||
| self.pipe_parallel_size > 1 and self.moe_num_experts == 1, | |||
| self.pipe_parallel_size >= 1 and self.moe_num_experts == 1, | |||
There was a problem hiding this comment.
I think we can remove the line about MoE, as that's already handled via a separate check that will throw an error.
There was a problem hiding this comment.
That said, I don't see any harm in this code. Just some potential unfriendliness to the casual reader.
Quentin-Anthony
previously approved these changes
Jun 7, 2024
Quentin-Anthony
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.