Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print 'Node Graph out of Date' messages in non-developer mode #344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FreeSlave
Copy link
Member

Note that in Valve repo the message printing is commented out https://github.com/ValveSoftware/halflife/blob/master/dlls/nodes.cpp#L1490
As a compromise we can still print it, but only in developer mode.

@a1batross
Copy link
Member

I think we forced printing it because when nodes wasn't shipped with the game for some reason, nodes generation without this iconic message make the game look like it's frozen.

@FreeSlave
Copy link
Member Author

I think the message stays for too long, longer than the node graph building usually takes. And there's no way to control the duration. But it's up to you.

@a1batross
Copy link
Member

Player knows when nodes generation is finished :)

@nekonomicon
Copy link
Member

I think the message stays for too long, longer than the node graph building usually takes.

Platform/CPU/Optflags-specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants