Increase dead message channel timeout #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider a message channel dead only after 10 min of silence, regardless of Debug or Release build mode. This should fix the observed rare event in Debug build, when communication between client extensions and Smart Card Connector was considered dead despite the pages staying alive seemingly.
|
Continuous Integration: All tests passed. |
AleksMat
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a message channel dead only after 10 min of silence, regardless of Debug or Release build mode.
This should fix the observed rare event in Debug build, when communication between client extensions and Smart Card Connector was considered dead despite the pages staying alive seemingly. This problem is especially disruptive in the manifest v3 extension build mode, since closing message ports can lead to the termination of service workers.