[pcsc] Retry init on more errors, try USB reset #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the tests failed - seems like a real problem with composite devices. Looking into it. |
|
Continuous Integration: All tests passed. |
Fixed now. |
Fabian-Sommer
approved these changes
May 15, 2024
Change the init retry mechanism to be triggered on any reader
initialization error, as opposed to only doing it on
openDevice/claimInterface errors. Additionally, attempt resetting the
USB device after a few unsuccessful retries.
This should fix occasional flaky errors we see in the field, when
there's a temporary conflict between the in-session and the login-screen
instances of Smart Card Connector, which may cause failures at various
USB functions and accidentally receiving a reply for a request sent by a
different extension ("Invalid frame detected").
emaxx-google
force-pushed
the
reset-usb-on-errors
branch
from
5d5e432
to
5c4116e
Compare
|
Continuous Integration: All tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the init retry mechanism to be triggered on any reader initialization error, as opposed to only doing it on openDevice/claimInterface errors. Additionally, attempt resetting the USB device after a few unsuccessful retries.
This should fix occasional flaky errors we see in the field, when there's a temporary conflict between the in-session and the login-screen instances of Smart Card Connector, which may cause failures at various USB functions and accidentally receiving a reply for a request sent by a different extension ("Invalid frame detected").