[mv3] Support popup windows - via message channels #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support of manifest v3 to the "popup-window" helpers. This is achieved by reimplementing the popup==>background page communication using message ports. Previously, we used two other mechanisms for this communication: * in the Chrome App build mode we injected callbacks into the popup's global state using the chrome.app.window.create() callback. * in the Chrome manifest v2 Extension build mode we used "setSelfAsOpener" to let the popup call global functions in the opener page itself. Neither works in manifest v3 Extensions, hence this commit implements a new approach that should work in all build modes.
|
Continuous Integration: All tests passed. |
|
Continuous Integration: All tests passed. |
|
Continuous Integration: All tests passed. |
|
Continuous Integration: All tests passed. |
|
I've guarded some code in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support of manifest v3 to the "popup-window" helpers. This is achieved by reimplementing the popup==>background page communication using message ports.
Previously, we used two other mechanisms for this communication:
Neither works in manifest v3 Extensions, hence this commit implements a new approach that should work in all build modes.