Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the use of non-image files as a background image #2206

Closed
wants to merge 4 commits into from

Conversation

0scvr
Copy link
Contributor

@0scvr 0scvr commented Oct 8, 2023

Please follow these steps before submitting a new Pull Request to Guake:

  • rebase on latest HEAD:

    $ git pull --rebase upstream master
  • hack your change

  • to execute the code styling, checks and unit tests:

    $ make style check reno-lint test
  • describe your change in a slug file for automatic release note
    generation, using:

    $ make reno SLUG=<short_name_of_my_feature>

    and edit the created file in releasenotes/notes/.
    You can see how reno works using pipenv run reno --help.

    Please use a generic slug (eg, for translation update,
    use translation, for bugfix use bugfix,...)

  • create new commit message

    $ <hack the code>
    $ git commit --all
  • If your change is related to a GitHub issue, you can add a reference
    using #123 where 123 is the ID of the issue.
    You can use closes #123 to have GitHub automatically close the issue
    when your contribution get merged

  • Semantic commit is supported (and recommended). Add one of the following
    line in your commit messages:

    # For a bug fix, uses:
    sem-ver: bugfix
    
    # For a new feature, uses:
    sem-ver: feature
    
    # Please do not use the 'breaking change' syntax (`sem-ver: api-break`),
    # it is reserved for really big reworks
    

Fixes #2205

@Davidy22
Copy link
Collaborator

Davidy22 commented Oct 8, 2023

The change looks fine, but looks like code style checks are moaning. Running black should resolve this, I assume it's because of the very long line that the set_string becomes with this patch.

@Davidy22
Copy link
Collaborator

Davidy22 commented Oct 9, 2023

Still a red cross, you should be able to enable CI on your fork to get faster feedback, running make check locally should also work.

@Davidy22
Copy link
Collaborator

Same check is complaining, if you just run black on the file it should do the formatting for you. Is make check passing locally for you?

@0scvr
Copy link
Contributor Author

0scvr commented Oct 10, 2023

Same check is complaining, if you just run black on the file it should do the formatting for you. Is make check passing locally for you?

make gives me errors. I think pipenv is the problem here.

@Davidy22
Copy link
Collaborator

You can also run black --check * to confirm this specific check. There may be others, but I think this is probably the only one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent users from setting non-image files as a background image
2 participants