Fix up and document delay() hack in uart receive #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is still a hack but a little bit less of one with an actual explanation instead of a scary comment. The correct thing is to do is advance through a state machine that detects the header and produces a symbol once it receives an entire message. But all my hardware is currently deployed with this code so we'll ship what's tested as opposed to what's theoretically correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a hack but a little bit less of one with an actual explanation instead of a scary comment.
The correct thing to do is advance through a state machine that detects the header and produces a symbol once we have received an entire message. But all my hardware is currently deployed with this code so we'll ship what's tested as opposed to what's theoretically correct.