Strip '\r' in notification messages to avoid 'Content-Type: application/octet-stream' #10061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on/octet-stream' Without this patch, an accidential `\r` in e.g. `$NOTIFICATIONCOMMENT` leads to a `Content-Type: application/octet-stream` header in e-mails. The accidential `\r` might slip in usually using Icinga/Nagios apps...
icinga-probot
bot
added
area/notifications
|
Tested by #7510 (comment) 👍 |
|
As the author of #7184 it's interesting and sad to see that it got reverted later by a wrong analysis. My PR did not change anything Bash or Dash related, the Debian-reported breakage/issue existed before already. So, thank you, @Al2Klimov, for the second attempt 5 years after mine. Oh, by the way: Do I need to sign the CLA even the same PR was initially accepted about 5 years ago already? If so, please let me know explicitly what you expect. |
|
At least it would be nice if you sign it. Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. |
yhabteab
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, an accidential
\rin e.g.$NOTIFICATIONCOMMENTleads to aContent-Type: application/octet-streamheader in e-mails. The accidential\rmight slip in usually using Icinga/Nagios apps...fixes #7510
ref/IP/6369
This is a cherry-pick of #6369.