Fixed local build issues (14" M1 MBP / macOS 12.3.1 #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbserra
commented
May 25, 2022
cbserra
commented
- Accepted XCode suggestions.
- Removed Carthage references to frameworks.
- Fixed metadata references to FuseSwift and SavannaKit frameworks.
…; fixed references to Fuse and Savana frameworks
cbserra
commented
May 25, 2022
| @@ -138,7 +138,6 @@ | |||
| 2C2066A121FE47090082570E /* PopoverViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PopoverViewController.swift; sourceTree = "<group>"; }; | |||
| 2C2066A321FE47CE0082570E /* PopoverView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PopoverView.swift; sourceTree = "<group>"; }; | |||
| 2C2066A521FE53870082570E /* SearchField.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SearchField.swift; sourceTree = "<group>"; }; | |||
| 2C3B003D22E3775300BBD4D0 /* SavannaKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = SavannaKit.framework; path = ../../../Carthage/Build/Mac/SavannaKit.framework; sourceTree = "<group>"; }; | |||
There was a problem hiding this comment.
Old Carthage reference removed. OK to do?
cbserra
commented
May 25, 2022
| @@ -154,7 +153,6 @@ | |||
| 2C9761DE2214E46800AFF8CD /* Script.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Script.swift; sourceTree = "<group>"; }; | |||
| 2C9761E02214E68D00AFF8CD /* ScriptTableViewCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ScriptTableViewCell.swift; sourceTree = "<group>"; }; | |||
| 2CA245DB224822EA00586DFD /* ScriptTableView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ScriptTableView.swift; sourceTree = "<group>"; }; | |||
| 2CB9D7F024319BAC00135424 /* Fuse.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Fuse.framework; path = ../../../Carthage/Build/Mac/Fuse.framework; sourceTree = "<group>"; }; | |||
There was a problem hiding this comment.
Old Carthage reference removed. OK to do?
cbserra
commented
May 25, 2022
| @@ -411,7 +409,7 @@ | |||
| isa = PBXProject; | |||
| attributes = { | |||
| LastSwiftUpdateCheck = 1100; | |||
| LastUpgradeCheck = 1010; | |||
| LastUpgradeCheck = 1330; | |||
There was a problem hiding this comment.
This and the rest of the file's edits I believe were modified by accepting XCode's suggestions. Was that ok?
cbserra
commented
May 25, 2022
| "revision": "bb51ee074152a7361e7085d10723f699c79fe673", | ||
| "version": "0.15.1" | ||
| } | ||
| "pins" : [ |
cbserra
commented
May 25, 2022
| @@ -97,7 +97,7 @@ extension Script: Fuseable { | |||
| } | |||
| } | |||
|
|
|||
| protocol ScriptDelegate: class { | |||
| protocol ScriptDelegate: AnyObject { | |||
cbserra
commented
May 25, 2022
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <Scheme | |||
| LastUpgradeVersion = "1100" | |||
| LastUpgradeVersion = "1330" | |||
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.