fix: allow version pass to avoid latest install always #8517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
mo-auto
added
area-CI
iromli
reviewed
May 16, 2024
| @@ -2,10 +2,10 @@ | |||
| set -eo pipefail | |||
| JANS_FQDN=$1 | |||
| JANS_PERSISTENCE=$2 | |||
| JANS_CI_CD_RUN=$3 | |||
| JANS_VERSION=$3 | |||
There was a problem hiding this comment.
@misba7 What's the default JANS_VERSION?
iromli
reviewed
May 16, 2024
| @@ -242,7 +239,7 @@ auth-server: | |||
| EOF | |||
| sudo helm repo add janssen https://docs.jans.io/charts | |||
| sudo helm repo update | |||
| sudo helm install janssen janssen/janssen -n jans -f override.yaml --kubeconfig="$KUBECONFIG" "$HELM_DEVELOPMENT_REPO" | |||
| sudo helm install janssen janssen/janssen -n jans -f override.yaml --kubeconfig="$KUBECONFIG" --version="$JANS_VERSION" | |||
There was a problem hiding this comment.
@misba7 have we handle empty $JANS_VERSION?
There was a problem hiding this comment.
empty JANS_VERSION installs latest, which was the default behavior.
I added the variable to be able to override it as needed.
There was a problem hiding this comment.
did you mean command like helm install --version= (empty JANS_VERSION) also work?
There was a problem hiding this comment.
ignore my last comment, i have tested it. The --version= <other-ops> is working while --version <other-ops> is not.
iromli
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8513