Feature/crt #5
Draft
Feature/crt #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thesan is attempting to deploy a commit to the Joystream DAO Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #4
So far all the changes are in the last commit
@kdembler the problem rn is that only Orion has CRT mappings, but oc Orion refuses cross origin requests. So either Orion should allow requests from some domain the tool will be hosted on, or a subset of the CRT mappings should be added to the QN. Personally I prefer the second solution.
Nevertheless I worked locally with mitmproxy (
mitmproxy --mode reverse:https://orion.gleev.xyz --listen-port 3001 --modify-headers '/~s/Access-Control-Allow-Origin/*') so I could to get a quick feedback on this feature. I'm not sure what's the best information to display. I picked to focussed onminted - burnedso it provides a single easy to understand number OTOH it might not give a full picture WDYT ?