-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement OneKey banner #823
Merged
bedeho
merged 8 commits into
Joystream:development
from
DzhideX:implement-onekey-banner
Mar 22, 2024
Merged
Implement OneKey banner #823
bedeho
merged 8 commits into
Joystream:development
from
DzhideX:implement-onekey-banner
Mar 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bedeho
approved these changes
Mar 22, 2024
this is excellent as is :) |
@bedeho Thank you! Design-wise I agree, but currently when you close out of the banner and refresh the page, the component flashes quickly before disappearing which is not the best UX. I'll open up the PR when I'm able to fix it (can't reproduce it locally...). |
There we go, fixed and ready to ship 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to implement feature explained here: #811
Question: