Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement changenow section #825

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

DzhideX
Copy link
Contributor

@DzhideX DzhideX commented Mar 23, 2024

This PR aims to implement the changenow section outlined here: #794

Note:

  • As the iframe doesn't support a width greater than 640px and a height greater than 356px I have taken some creative liberties in adjusting the design to accommodate that.

Copy link

vercel bot commented Mar 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
joystream-org ✅ Ready (Inspect) Visit Preview Mar 23, 2024 4:53pm
joystream-org-storybook ✅ Ready (Inspect) Visit Preview Mar 23, 2024 4:53pm
joystream-org-translation ✅ Ready (Inspect) Visit Preview Mar 23, 2024 4:53pm

@bedeho
Copy link
Member

bedeho commented Mar 23, 2024

Does this use the API key for Jsgenesis?

@bedeho
Copy link
Member

bedeho commented Mar 23, 2024

We def. need a way to link explicitly to this section, is that possible?

@DzhideX
Copy link
Contributor Author

DzhideX commented Mar 23, 2024

Does this use the API key for Jsgenesis?

I believe so. The code snippet for the widget was given to me by @WRadoslaw. It uses the following id (which I think is the relevant part): link_id=836b188968aaa.

We def. need a way to link explicitly to this section, is that possible?

Certainly! At the moment to link to this section we append #instantSwap to the URL of the token page. Let me know if we want to change that value to something else! Right now it looks like this: https://joystream-org-git-fork-dzhidex-implement-changenow-joystream.vercel.app/token#instantSwap

@bedeho
Copy link
Member

bedeho commented Mar 23, 2024

Certainly! At the moment to link to this section we append #instantSwap to the URL of the token page. Let me know if we want to change that value to something else! Right now it looks like this: https://joystream-org-git-fork-dzhidex-implement-changenow-joystream.vercel.app/token#instantSwap

Ok great, but can we add like a button or something, which allows someone to copy a link to the section? I know the people manning our chats and so on would have an easier time providing assistance to people with that.

@DzhideX
Copy link
Contributor Author

DzhideX commented Mar 24, 2024

We could add a button or similar, but I have some reservations with regards to it. The id approach is also used for other sections on the page without issues and they also don't have any buttons for this (examples: token#exchanges, token#earn). I just fail to see what problem we're trying to solve with this approach 🤔

If you still want to go for it then I'll add it 👍

@bedeho
Copy link
Member

bedeho commented Mar 24, 2024

ok, but how will people keep track of and learn waht the links are for each section?

@DzhideX
Copy link
Contributor Author

DzhideX commented Mar 24, 2024

Up until now, it's only been a handful of people that have needed it (tomato, Dmitry, HR workers), and usually, if they needed a link to a section they'd ask if there is one, if not I created them. This approach is also the standard way to link to different parts of pages across the web so I don't think people would be unfamiliar with it either (example: https://en.wikipedia.org/wiki/Blockchain#Blocks).

@bedeho bedeho merged commit dd95836 into Joystream:development Mar 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants